Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat#17 modal #18

Merged
merged 9 commits into from
Apr 17, 2024
Merged

Feat#17 modal #18

merged 9 commits into from
Apr 17, 2024

Conversation

zoonyoung
Copy link
Contributor

๐Ÿ“Œ ์ฃผ์š” ์‚ฌํ•ญ

  • Modal ์ปดํฌ๋„ŒํŠธ ๊ตฌํ˜„ ( ์™ธ๋ถ€ ํด๋ฆญ์‹œ ์ข…๋ฃŒ, ์Šคํฌ๋กค ๋ฐฉ์ง€ ๊ธฐ๋Šฅ )
  • RegestrationModal, RejectionModal ๊ตฌํ˜„
  • useOutsideClick ํ›… ์ƒ์„ฑ
  • color-box mixin ์ƒ์„ฑ
    ์‚ฌ์šฉ์ฒ˜์—์„œ @include color-box;
    ์‚ฌ์šฉ ๊ธฐ๋ณธ ์„ค์ •๊ฐ’ fill false color $red-400์ปฌ๋Ÿฌ
    color-box(fill, color: $red-200) ์ด๋Ÿฐ ์‹์œผ๋กœ ์‚ฌ์šฉ ๊ฐ€๋Šฅ!
@mixin color-box($fill: false, $color: $red-400) {
  padding: 0.6rem 1rem;
  border: 1px solid $color;
  @include rounded-lg;

  @if $fill {
    background-color: $color;
    color: $white;
  }

  @else {
    background: none;
    color: $color;
  }
}

๐Ÿ“ท ์Šคํฌ๋ฆฐ์ƒท

image

๐Ÿ’ฌ ์š”์ฒญ์‚ฌํ•ญ[์„ ํƒ]

  • ์ผ๋‹จ ๊ณตํ†ต์ปดํฌ๋„ŒํŠธ์— ์žˆ๋Š” ๊ธฐ๋ณธ ๋ชจ๋‹ฌ ๋‘๊ฐœ๋ฅผ ๋งŒ๋“ค์—ˆ๋Š”๋ฐ ๋ชจ๋‹ฌ ์ด๋ฆ„ ๊ณ ๋ฅด๊ธฐ๊ฐ€ ์‰ฝ์ง€ ์•Š๋”๋ผ๊ตฌ์š” ํ•จ ๋ณด์‹œ๊ณต ์ถ”์ฒœ ๋ถ€ํƒ ๋“œ๋ฆฝ๋‹ˆ๋‹ค

#๏ธโƒฃ ์—ฐ๊ด€ ์ด์Šˆ๋ฒˆํ˜ธ

#17

setIsRendering(false);
}, []);

if (isRendering) return null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ด„ํ˜ธ๋กœ ๊ฐ์‹ธ์ฃผ์‹œ๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•— {} ํ•˜๊ธฐ๋กœํ–ˆ์—ˆ์ช„? ์ˆ˜์ • ํ•˜๋„๋ก ํ•˜๊ฒ ์Šด๋‹ค.

Copy link
Contributor

@armd482 armd482 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ชจ๋‹ฌ ์ด๋ฆ„์€ ์ €๋Š” ๊ดœ์ฐฎ์€ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค. ์กฐ๊ธˆ ๋” ์ง๊ด€์ ์œผ๋กœ ํ•˜๋ ค๋ฉด
CheckRejectionModal
RequestRegitrationModal
์ •๋„ ์ƒ๊ฐํ•ด๋ณผ ์ˆ˜ ์žˆ์„ ๊ฒƒ ๊ฐ™์€๋ฐ, ๋„ˆ๋ฌด ๊ธธ์–ด์„œ...

@zoonyoung zoonyoung merged commit 25b12a4 into develop Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants